Merge pull request #132 from alfonsosanchezbeato/fix-focal-run

Use patchelf to make sure the dynamic linker from the base is used

debian/changelog

@@ -13,6 +13,9 @@ ubuntu-image (3.0+23.04ubuntu2) UNRELEASED; urgency=medium
   * Don't scan build machine for OS entries when generating GRUB config:
     dpkg-divert os-prober around update-grub.
 
+  [ Alfonso Sanchez-Beato ]
+  * Run patchelf so we get dynamic linker and libs from the core22 base.
+
  -- mjdonis <[email protected]>  Thu, 11 May 2023 12:29:08 +0200
 
 ubuntu-image (2.2+22.10ubuntu1) kinetic; urgency=medium

snapcraft.yaml

@@ -3,7 +3,7 @@ summary: Create Ubuntu images
 description: |
   Official tool for building Ubuntu images, currently supporing Ubuntu Core
   snap-based images and preinstalled Ubuntu classic images.
-version: 3.0+snap3
+version: 3.0+snap4
 grade: stable
 confinement: classic
 base: core22
@@ -22,7 +22,7 @@ apps:
 
 parts:
   ubuntu-image:
-    plugin: go
+    plugin: nil
     source: .
     source-type: git
     build-packages:
@@ -42,8 +42,15 @@ parts:
       - make
       - kpartx
       - qemu-utils
+    build-attributes: [ enable-patchelf ]
     override-build: |
-      snapcraftctl build
+      ins_bin=$SNAPCRAFT_PART_INSTALL/bin/
+      mkdir -p "$ins_bin"
+      # Make ubuntu-image statically compiled to avoid libc deps.
+      # We need this as setting interpreter/rpath is known to cause
+      # issues with go binaries (https://github.com/NixOS/patchelf/issues/146).
+      # On compiling statically go, see https://mt165.co.uk/blog/static-link-go/
+      CGO_ENABLED=0 go build -o "$ins_bin" ./cmd/ubuntu-image/
       # create a symlink /usr/bin/fakeroot -> /usr/bin/fakeroot-tcp
       cd $SNAPCRAFT_PART_INSTALL/usr/bin/
       ln -s fakeroot-tcp fakeroot