kvm-test: add the option to "overwrite" an existing installation without recreating the disk from scratch #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogayot
force-pushed
the
kvm-test-reuse-target
branch
from
e641687
to
34bcc61
Compare
kvm-test has three new options (with only the third one being really new). * `--preserve-target` which is an explicit way to abort if the target image already exists (this is the default behavior) * `--recreate-target` which mimics what `-o` / `--overwrite` does (i.e., recreating the target image even if it already exists). * `--reuse-target` which is the new one. When the option is supplied, we will reuse the disk without recreating it (if it already exists). When using the --reuse-target option, the firmware will try to boot from the disk. To work around the issue, quickly hit ESC and select `Boot Manager -> UEFI QEMU DVD-ROM`. Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
kvm-test-reuse-target
branch
from
34bcc61
to
7fa0754
Compare
Chris-Peterson444
approved these changes
Oct 3, 2024
Good point, TIL |
dbungert
approved these changes
Oct 8, 2024
…arget Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
kvm-test-reuse-target
branch
from
7fa0754
to
d0ae2da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
kvm-testwith--install, we currently have two options related to the target disk:--overwriteoption (or-o) is passed, we instead recreate the target image from scratch.This makes us unable to supply an already partitioned disk to kvm-test, which is a bit of a shame considering the use-cases we have currently.
This change adds 3 new options (well, only one is truly new):
--preserve-targetwhich is an explicit way to abort if the target image already exists (this is the default behavior)--recreate-targetwhich mimics what-o/--overwritedoes.--reuse-targetwhich is the new one. When the option is supplied, we will reuse the disk without recreating it (if it already exists).When we install to an existing disk with
--reuse-target, we need to ask the firmware to boot from the installation media (or it will prefer booting from the disk if there is something installed to it). In BIOS mode, this means adding the-boot order=doption. However, in UEFI mode, it is more difficult to do. For now, I've added a note to stderr to tell how to proceed with UEFI (i.e., mashing ESC and then selectingBoot Manager->UEFI QEMU DVD-ROM). Suggestions welcome :)