-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pro: replace deprecated cloud-init key ubuntu_advantage #2069
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,11 +38,8 @@ def make_cloudconfig(self) -> dict: | |
""" | ||
if not self.token: | ||
return {} | ||
# Both "ubuntu_advantage" and "ubuntu-advantage" keys are accepted, but | ||
# "ubuntu-advantage" is deprecated despite not being mentioned in the | ||
# documentation. | ||
return { | ||
"ubuntu_advantage": { | ||
"ubuntu_pro": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ogayot looks good to me. Moving to There are two uploads under review that will make this valid as well for 16.04 and 18.04 if that becomes something you need to support, but that hasn't landed yet. |
||
"token": self.token, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encoding a token publicly in a repo gave me pause, but Just confirmed that this token is, in fact, invalid/not real and cannot be used to attach.