Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background work to prepare move to v2 storage API in the client #2017

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Background work to prepare move to v2 storage API in the client #2017

wants to merge 4 commits into from

Commits on Jul 25, 2024

  1. async_helpers: only pass a single positional argument to create_task 

    asyncio.create_task only accepts one positional argument and passing
more than one results in the following exception:

TypeError: create_task() takes 1 positional argument but 2 were given

Therefore, it does not make sense for run_bg_task to forward *args to
it. We now use explicit keyword argument names.

Signed-off-by: Olivier Gayot <[email protected]>
    @ogayot
    ogayot committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1267818 View commit details
    Browse the repository at this point in the history

  2. async_helpers: add way to associate a coroutine to an urwid signal 

    Signed-off-by: Olivier Gayot <[email protected]>
    @ogayot
    ogayot committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e6c8823 View commit details
    Browse the repository at this point in the history

  3. storage: client: accept coroutines as actions 

    Signed-off-by: Olivier Gayot <[email protected]>
    @ogayot
    ogayot committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ca8c522 View commit details
    Browse the repository at this point in the history

  4. storage: make storage manipulator async ready 

    Going forward, the client storage/filesystem controller should perform
all of the storage actions by making async calls to the API. These calls
will be implemented using coroutines functions that will call aiohttp.

At the start, these new coroutine functions will override the methods
from the manipulator. However, the functions defined by the manipulator
are not coroutines functions so there is a mismatch.

Move the needed functions to coroutine functions so that we can properly
override them with coroutine functions.

Signed-off-by: Olivier Gayot <[email protected]>
    @ogayot
    ogayot committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6df6d68 View commit details
    Browse the repository at this point in the history