ubuntu-image docs fixes & updates #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbungert
approved these changes
Mar 8, 2024
upils
requested changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM but it looks like you missed 3 comments from the previous review:
- Add ubuntu-image reference #1929 (comment)
- Add ubuntu-image reference #1929 (comment)
- Add ubuntu-image reference #1929 (comment)
They are not marked as resolved so I do not know if you missed them or did not deal with them en purpose.
Not on purpose -- I didn't see them. I pbbly opened the review before you were finished, and I didn't reload. My bad. I'll add fixes for these, too. |
rkratky
force-pushed
the
ubuntu-image-fixes
branch
from
b3948f6
to
a10002e
Compare
|
@upils I added the remaining fixes based on yyour review. Apologies for having missed those before. |
rkratky
force-pushed
the
ubuntu-image-fixes
branch
from
a10002e
to
bb4d7c6
Compare
upils
requested changes
Mar 13, 2024
rkratky
force-pushed
the
ubuntu-image-fixes
branch
from
bb4d7c6
to
6d7d177
Compare
rkratky
force-pushed
the
ubuntu-image-fixes
branch
3 times, most recently
from
e652d78
to
500c8bf
Compare
rkratky
force-pushed
the
ubuntu-image-fixes
branch
from
500c8bf
to
b94abac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1929. Minor fixes, updates, and additions to the
ubuntu-imagereference doc.