-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validate-autoinstall-user-data script #1901
Merged
Chris-Peterson444
merged 13 commits into
canonical:main
from
Chris-Peterson444:user-data-validation
Aug 29, 2024
Merged
Update validate-autoinstall-user-data script #1901
Chris-Peterson444
merged 13 commits into
canonical:main
from
Chris-Peterson444:user-data-validation
Aug 29, 2024
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2dbb642 - Browse repository at this point
Copy the full SHA 2dbb642View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14ac6e0 - Browse repository at this point
Copy the full SHA 14ac6e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38eeb00 - Browse repository at this point
Copy the full SHA 38eeb00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f27c9d - Browse repository at this point
Copy the full SHA 2f27c9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 255d662 - Browse repository at this point
Copy the full SHA 255d662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f66026 - Browse repository at this point
Copy the full SHA 0f66026View commit details
Commits on Jul 31, 2024
-
In the future we want to use dry-run and subiquity internals to do more robust validation of autoinstall user-data. Today the CI isn't ready for this and we should rely on old behavior to not regress CI results. This effectively moves current behavior behind the --legacy flag.
Configuration menu - View commit details
-
Copy full SHA for fcd2623 - Browse repository at this point
Copy the full SHA fcd2623View commit details -
validation: link checking is CI only
With moving to make the validation script more user facing, we don't need users to have the documentation link in their autoinstall file. Add a hidden flag, --check-link, to be used in CI to validate rendered autoinstall config has the documentation link.
Configuration menu - View commit details
-
Copy full SHA for 3181d3a - Browse repository at this point
Copy the full SHA 3181d3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8451ae6 - Browse repository at this point
Copy the full SHA 8451ae6View commit details -
validate: use dry-run server for validation
./scripts/validate-autoinstall-user-data is used by the integration tests to verify the rendered user data validates against the combined JSON schema, but we have introduced run-time checks for more things than can be caught by simple JSON validation (e.g. warns/errors on unknown keys or strict top-level key checking for supporting a top-level "autoinstall" keyword in the non-cloud-config delivery scenario). Now the validation logic relies on the server validation logic directly to perform pre-validation of the the supplied autoinstall configuration.
Configuration menu - View commit details
-
Copy full SHA for d38f007 - Browse repository at this point
Copy the full SHA d38f007View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aee359 - Browse repository at this point
Copy the full SHA 9aee359View commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04f06be - Browse repository at this point
Copy the full SHA 04f06beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79217f4 - Browse repository at this point
Copy the full SHA 79217f4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.