Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oem: make sure storage is configured before using is_core_boot_classic #1809

Merged
merged 1 commit into from
Sep 27, 2023

Commits on Sep 27, 2023

  1. oem: make sure storage is configured before using is_core_boot_classic

    Before using fs_controller.is_core_boot_classic(), we wait for the call
    to /meta/confirmation?tty=xxx. That said, in semi-automated desktop
    installs, sometimes the call to /meta/confirmation happens before
    marking storage configured. This leads to the following error:
    
      File "subiquity/server/controllers/oem.py", line 209, in apply_autoinstall_config
        await self.load_metapkgs_task
      File "subiquity/server/controllers/oem.py", line 81, in list_and_mark_configured
        await self.load_metapackages_list()
      File "subiquitycore/context.py", line 149, in decorated_async
        return await meth(self, **kw)
      File "subiquity/server/controllers/oem.py", line 136, in load_metapackages_list
        if fs_controller.is_core_boot_classic():
      File "subiquity/server/controllers/filesystem.py", line 284, in is_core_boot_classic
        return self._info.is_core_boot_classic()
    AttributeError: 'NoneType' object has no attribute 'is_core_boot_classic'
    
    Receiving the confirmation before getting the storage configured is
    arguably wrong - but let's be prepared for it just in case.
    
    Signed-off-by: Olivier Gayot <[email protected]>
    ogayot committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    59849f7 View commit details
    Browse the repository at this point in the history