-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for specifying the autoinstall file over the kernel command line #1803
Allow for specifying the autoinstall file over the kernel command line #1803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc update please, and please rebase the commits down to one or two. Doc update could arguably be a distinct commit. We don't use the squash merge feature so the commits should be long-term interesting.
Take a peek at recent commit history for the convention being used, for instance "initial fix" is more generic than I would like.
Thanks!
62d785f
to
c41e07f
Compare
Docs updated and commits rebased. Let me know if you would like the section in the doc to be elaborated further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. One doc tweak and this is done.
c41e07f
to
28dd55f
Compare
# 2. command line argument autoinstall | ||
# 3. autoinstall supplied by cloud config | ||
# 4. autoinstall baked into the iso, found at /cdrom/autoinstall.yaml | ||
# 1. command line argument autoinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for move CLI argument up the chain. It feels more natural.
This change allows for specifying the location of the autoinstall.yaml file in the kernel command line via
subiquity.autoinstallpath
. So, something likesubiquity.autoinstallpath=path/to/autoinstall.yaml
.I have additionally changed the precedence for the various ways the autoinstall file may be passed from:
To:
For the tests:
None
for the subiquity arg when the case is no arg is passed), instead of simply leaving them undefined.