Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oem: fix IndexError when using OEMController.wants_oem_kernel #1767

Merged
merged 1 commit into from
Aug 18, 2023
Merged

oem: fix IndexError when using OEMController.wants_oem_kernel #1767

merged 1 commit into from
Aug 18, 2023

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented Aug 17, 2023 

Traceback (most recent call last):
    File "subiquity/server/controllers/oem.py", line 161, in load_metapackages_list
      self.model.metapackages = [
    File "subiquity/server/controllers/oem.py", line 164, in <listcomp>
      wants_oem_kernel=await self.wants_oem_kernel(
    File "subiquity/server/controllers/oem.py", line 115, in wants_oem_kernel
      flavor = line.split("=", maxsplit=1)[1].strip()
  IndexError: list index out of range

mwhudson
mwhudson approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@mwhudson mwhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Black seems sad?

@ogayot
oem: fix IndexError when using OEMController.wants_oem_kernel
bf42341 
  Traceback (most recent call last):
    File "subiquity/server/controllers/oem.py", line 161, in load_metapackages_list
      self.model.metapackages = [
    File "subiquity/server/controllers/oem.py", line 164, in <listcomp>
      wants_oem_kernel=await self.wants_oem_kernel(
    File "subiquity/server/controllers/oem.py", line 115, in wants_oem_kernel
      flavor = line.split("=", maxsplit=1)[1].strip()
  IndexError: list index out of range

Signed-off-by: Olivier Gayot <[email protected]>
@ogayot ogayot merged commit a237552 into canonical:main Aug 18, 2023
10 checks passed
@ogayot ogayot deleted the fix-wants-oem-kernel branch August 18, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwhudson mwhudson mwhudson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogayot @mwhudson