filesystem: Use the first fitting gap for ESP, instead of the largest gap #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medicalwei
force-pushed
the
if-esp-fits-it-sits
branch
from
023cd47
to
653f004
Compare
medicalwei
force-pushed
the
if-esp-fits-it-sits
branch
from
653f004
to
8b70d47
Compare
mwhudson
reviewed
Aug 16, 2023
| gap = gaps.largest_gap(device, in_extended=False) | ||
| if gap is not None and gap.size >= size and gap.is_usable: | ||
| # find the first available gap (not always the largest one) | ||
| gap = next( |
There was a problem hiding this comment.
I generally prefer explicit for loops to this kind of thing but well
dbungert
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
This is an improvement but I think we should relocate this to gaps.py at some point. Can easily imagine other cases of wanting a gap that supports a certain size instead of always demanding the largest.
Note that this code doesn't check the criteria where a gap would be unusable (TOO_MANY_PRIMARY_PARTS) but I guess that's not a scenario here.
|
@medicalwei Thanks for the PR, but I think it's obsolete given the implementation in #1765 |
|
Closing this in favor of #1765, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle the issue, that when using recovery (reset) partition to install to the same disk, it:
This should not affect disk installation where the disk partitions are all removed, but affects installations where there are some partitions exist but not removed.