Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 'dd' image sources #1752

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

mwhudson
Copy link
Collaborator

@mwhudson mwhudson commented Aug 2, 2023

I think only a core dd image source will work for now. Probably.

@mwhudson
Copy link
Collaborator Author

mwhudson commented Aug 2, 2023

With this and the other just-proposed PRs I can install core desktop \o/

Please feel free to suggest ways to split this commit up!

Copy link
Collaborator

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are mad, and a integration test (or pseudo-integration test in the unit tests) would be nice.

otherwise makes sense and LGTM.

I think only a core dd image source will work for now. Probably.
@mwhudson mwhudson requested a review from dbungert August 2, 2023 22:02
@mwhudson
Copy link
Collaborator Author

mwhudson commented Aug 2, 2023

Can you take a look at what I did to the integration tests?

@mwhudson mwhudson merged commit c34e30f into canonical:main Aug 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants