generalize the way screens are skipped when installing desktop #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also skip identity screen when installing neither server nor desktop (i.e. core).
mwhudson
force-pushed
the
generalize-screen-skipping
branch
from
e000524
to
f838fca
Compare
dbungert
approved these changes
Jul 18, 2023
| @@ -62,6 +62,8 @@ class IdentityController(SubiquityController): | |||
| 'additionalProperties': False, | |||
| } | |||
|
|
|||
| interactive_for_variants = {'desktop', 'server'} | |||
There was a problem hiding this comment.
I think desktop wants to not be on this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also skip identity screen when installing neither server nor desktop (i.e. core).