feat: Implement CA certificate renewal #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruyaume
requested changes
Sep 12, 2024
saltiyazan
force-pushed
the
TLSENG-343
branch
from
439b8c3
to
b3b93c6
Compare
gruyaume
requested changes
Sep 13, 2024
saltiyazan
force-pushed
the
TLSENG-343
branch
from
4f8127d
to
2891163
Compare
saltiyazan
force-pushed
the
TLSENG-343
branch
from
2891163
to
51e0cc7
Compare
saltiyazan
force-pushed
the
TLSENG-343
branch
from
daa77a0
to
f445de0
Compare
saltiyazan
force-pushed
the
TLSENG-343
branch
from
4fafed7
to
e3aa0df
Compare
saltiyazan
force-pushed
the
TLSENG-343
branch
2 times, most recently
from
35cb466
to
4ee5f7b
Compare
gruyaume
requested changes
Sep 17, 2024
7 tasks
saltiyazan
force-pushed
the
TLSENG-343
branch
from
da0e3ca
to
9fb803f
Compare
gruyaume
requested changes
Sep 18, 2024
saltiyazan
force-pushed
the
TLSENG-343
branch
3 times, most recently
from
0615c69
to
d9fd25f
Compare
saltiyazan
force-pushed
the
TLSENG-343
branch
from
d9fd25f
to
392fda8
Compare
gruyaume
approved these changes
Sep 23, 2024
kayra1
reviewed
Sep 24, 2024
Comment on lines
+132
to
+142
| type: string | ||
| default: 90d | ||
| description: > | ||
| Signed certificate validity. | ||
| The given value must be followed by one of: "m" for minutes, "h" for hours, "d" for days and "w" for weeks. | ||
| For example, "1m" for 1 minute, "10w" for 10 weeks. | ||
| If no units are given, the unit will be assumed as days. | ||
| Defaults to 90 days. | ||
| This value should be equal to or shorter than half the root-ca-validity. | ||
| Changing this value will trigger generation of a new CA certificate, | ||
| revoking all previously issued certificates. |
There was a problem hiding this comment.
Did we ever talk with Judit Novak to make sure that a minimum value of 1 minute is OK for integration tests?
There was a problem hiding this comment.
Yes, that's good enough for them.
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #238, #239 and #241
Checklist: