Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo #682

Merged
merged 5 commits into from
Sep 4, 2024
Merged

docs: fix typo #682

merged 5 commits into from
Sep 4, 2024

Conversation

jy5275
Copy link
Contributor

@jy5275 jy5275 commented Aug 27, 2024

  • [ √] Have you signed the CLA?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 27, 2024
cjdcordeiro
cjdcordeiro reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @jy5275 . it lgtm , but could you please sign the CLA :)

@jy5275
Copy link
Contributor Author

jy5275 commented Aug 27, 2024

thanks for the fix @jy5275 . it lgtm , but could you please sign the CLA :)

Done

@clay-lake
Copy link
Contributor

clay-lake commented Aug 28, 2024 •
edited
Loading

Hi @jy5275, Our automated CLA check is still failing.

Could you edit your CLA comment to use 'x' instead of '√'

For example:

[x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?

cjdcordeiro
cjdcordeiro reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now. thanks @jy5275

@lengau lengau linked an issue Sep 4, 2024 that may be closed by this pull request
Typo fix #695
Closed
@tigarmo tigarmo merged commit 371bc72 into canonical:main Sep 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@clay-lake clay-lake clay-lake approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo fix
5 participants
@jy5275 @clay-lake @tigarmo @cjdcordeiro @lengau