feat: Automate schema validation in a github workflow job #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
force-pushed
the
ROCKS-968/feat/automate-validation-for-generated-schema
branch
from
60abecd
to
be39eee
Compare
|
@cjdcordeiro @tigarmo Ready for review. |
cjdcordeiro
requested changes
Jan 24, 2024
Yes, see here for instance. |
|
@linostar can you add a commit that breaks that example rockcraft.yaml so we can see what a validation failure looks like? |
Sure! missing_required_test, additional_field_test and invalid_schema_test. |
Looks great! thanks a lot |
tigarmo
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new job was added to
schema.yamlworkflow in order to automate the validation of Rockcraft schema.ajv-cli tool was used for validation. It is one of the fastest and most comprehensive JsonSchema validation tools. It was used with
--strict=falseoption to allow"format": "uri"in the schema.ajv-cli was able to detect validation errors similarly to JsonSchema-using IDEs like VS Code and PyCharm.