Skip to content

Commit

Permalink
fix(flask): drop 'flask-framework/' prefix in template (#615)
Browse files Browse the repository at this point in the history
runtime-slices and runtime-debs aren't parts that the extension is aware of,
so prefixing them with 'flask-framework/' is misleading and a conceptual
error.
  • Loading branch information
tigarmo authored Jun 25, 2024
1 parent df70cc4 commit f0d5480
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions rockcraft/commands/init.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,19 +143,19 @@ class InitCommand(AppCommand):
# add this part if you want to add packages slices to your image.
# you can find a list of packages slices at https://github.com/canonical/chisel-releases
# flask-framework/runtime-slices:
# runtime-slices:
# plugin: nil
# stage-packages:
# # list the required package slices for your flask application below.
# # for example, for the slice libs of libpq5:
# - libpq5_libs
# # list the required package slices for your flask application below.
# # for example, for the slice libs of libpq5:
# - libpq5_libs
# if you want to add a Debian package to your image, add the next part
# flask-framework/runtime-debs:
# runtime-debs:
# plugin: nil
# stage-packages:
# # list required Debian packages for your flask application below.
# - libpq5
# # list required Debian packages for your flask application below.
# - libpq5
"""
),
doc_slug="/reference/extensions/flask-framework",
Expand Down
14 changes: 7 additions & 7 deletions tests/unit/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,19 +190,19 @@ def test_run_init_flask(mocker, emitter, monkeypatch, new_dir, tmp_path):
# add this part if you want to add packages slices to your image.
# you can find a list of packages slices at https://github.com/canonical/chisel-releases
# flask-framework/runtime-slices:
# runtime-slices:
# plugin: nil
# stage-packages:
# # list the required package slices for your flask application below.
# # for example, for the slice libs of libpq5:
# - libpq5_libs
# # list the required package slices for your flask application below.
# # for example, for the slice libs of libpq5:
# - libpq5_libs
# if you want to add a Debian package to your image, add the next part
# flask-framework/runtime-debs:
# runtime-debs:
# plugin: nil
# stage-packages:
# # list required Debian packages for your flask application below.
# - libpq5
# # list required Debian packages for your flask application below.
# - libpq5
"""
)
emitter.assert_message(
Expand Down

0 comments on commit f0d5480

Please sign in to comment.