Adjust sentinel config directory permission to proactively prepare for pebble v1.15 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Juju 3.6 will upgrade from pebble v1.10.2 to v1.15.0 which includes the following PR: canonical/pebble#423
TLDR; pebble did not account for umask previous to this PR. so if one uses
pebble mkdirwith permissions770or777, umask will de-escalate privileges to755. however, with this PR, the permissions for a newly created directory will be exactly what one specifiesSolution
Since sentinel config directory (created with
770) is actually being de-escalated to750, change the permissions to it explicitly to avoid surprises when upgrading to juju 3.6