Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5200] add leader info to relation data #96

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

reneradoi
Copy link
Contributor

@reneradoi reneradoi commented Aug 21, 2024

Issue

With #95 the Discourse team requests to have the Redis Sentinel leader information in the relation data.

Solution

On updates to the Sentinel leader and when a new relation to redis is created, add the leader information to the relation data of all related applications.

Note

It also fixes an issue with metadata.yaml, which caused builds to fail: With a recent charmcraft update, the summary in metadata.yaml must not be longer than 200 chars anymore.

@alithethird
Copy link

alithethird commented Aug 23, 2024

Hi Rene! Thanks for the changes. Do you plan to also update the library to get the master ip directly? I think also the url function in the library should be updated too.

Copy link

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we will rewrite the external relations lib / contract to align with the DP interfaces - as those are legacy interfaces, so I see no harm in this PR for the time being.

@reneradoi reneradoi merged commit 63b8cfa into main Aug 26, 2024
9 checks passed
@reneradoi reneradoi deleted the add-leader-info-to-relation-data branch August 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants