Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add type hinting to test_lib #1012

Merged
merged 7 commits into from
Sep 25, 2023
Merged

test: add type hinting to test_lib #1012

merged 7 commits into from
Sep 25, 2023

Commits on Sep 24, 2023

  1. Ensure that we don't backslide.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    479a69a View commit details
    Browse the repository at this point in the history

  2. Don't check debug log output.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    4207407 View commit details
    Browse the repository at this point in the history

  3. Don't test log output.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    58b74d0 View commit details
    Browse the repository at this point in the history

  4. We no longer require the logassert package.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    215b0cd View commit details
    Browse the repository at this point in the history

  5. Add type hints for private functions, so the tests can use them.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    ee5d087 View commit details
    Browse the repository at this point in the history

  6. Add type hints. 

    * Stop testing debug level logs.
* Ignore the type checking when we are deliberately checking for bad type handling.
* Pass a dummy spec rather than None, to avoid type complaints.
* Work around an optional argument.
    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    79a509d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Avoid 3.10+ test method.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    db228e9 View commit details
    Browse the repository at this point in the history