Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group articles of the Explanation section into proper subsections #97

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

nbarbarick
Copy link
Contributor

This addresses #80 and its copy here: canonical/open-documentation-academy#115.

@jugmac00
Copy link
Member

Hi @nbarbarick,

Thanks for your patience!

And especially thanks for your contribution!

This looks great and is almost ready to be merged.

I think it makes a lot of sense to make the page uniform by applying the same nested toc strategy to the JavaScript, Static Assets and Database sections.

Could you please do that?

@nbarbarick
Copy link
Contributor Author

Hi @jugmac00,

I have added the remaining subsections to the ToC. Please let me know if you'd like anything else with this, such as descriptions for those new sections, or if we should close this issue and its twin here: canonical/open-documentation-academy#115.

@jugmac00
Copy link
Member

jugmac00 commented Sep 4, 2024

Thanks so much. Things have been quite busy, I will look as soon as I find some time.

@jugmac00
Copy link
Member

jugmac00 commented Sep 5, 2024

@nbarbarick Thanks for your patience and your dedication!

I think this looks very good. As you mentioned, and in order to make this complete, we should add an introductionary sentence to the remaining three sections, ie JavaScript, Static assets, and Database - then we are ready to merge.

Could you please do that?

Thanks so much!

@nbarbarick
Copy link
Contributor Author

Hi @jugmac00, I ran into a few issues when updating my pull request and incorporating other changes. Please let me know of any issues or guidance for how I can resolve any potential errors. Thank you.

@jugmac00
Copy link
Member

@nbarbarick Thanks for reaching out! This week I won't be able to help, but certainly the one after it. Could you let me know what kind of issues you ran into?

@nbarbarick
Copy link
Contributor Author

Yes, I think it was that I had some trouble moving a page referenced in another commit. That page was added to the ToC in a way that conflicted with the ToC that we've been working on in this pull request. I had to resolve the conflict in a part of GitHub I've never seen before, so I'm not sure if I did that correctly.

@alvaro-crespo alvaro-crespo merged commit 1fcb3a9 into canonical:main Sep 30, 2024
2 checks passed
@alvaro-crespo
Copy link
Contributor

Hi @nbarbarick, changes look good to me. Thanks a lot for your contribution! Happy to accept the merge.

@jugmac00 jugmac00 added the Open Documentation Academy Community contribution via https://canonical.com/documentation/open-documentation-academy label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Open Documentation Academy Community contribution via https://canonical.com/documentation/open-documentation-academy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants