Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for pynacl to "Setting up and running Launchpad" #93

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add fix for pynacl to "Setting up and running Launchpad" #93

merged 1 commit into from
Aug 7, 2024

Conversation

ikoruk
Copy link
Contributor

@ikoruk ikoruk commented Jul 26, 2024

  • doc: update running launchpad how-to with pynacl fix for arm64

@ikoruk
Copy link
Contributor Author

ikoruk commented Jul 26, 2024

Please tell me if you think I should also add another page in this PR for running in a Docker container

ineesalmeida
ineesalmeida approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ineesalmeida ineesalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice to see these troubleshooting sections growing!

About the docker topic:
I think a page about how to run launchpad in a docker container seems interesting.
Out of curiosity, did you feel like the setup steps are simpler, or similar?

how-to/running.rst Outdated Show resolved Hide resolved
lgp171188
lgp171188 reviewed Jul 26, 2024
View reviewed changes
how-to/running.rst Outdated Show resolved Hide resolved
lgp171188
lgp171188 requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@lgp171188 lgp171188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about using a vendored sdist of PyNaCl.

@ikoruk
Copy link
Contributor Author

ikoruk commented Jul 29, 2024

did you feel like the setup steps are simpler, or similar

I based it on Clint's Dockerfile which has a few more steps than the documentation. But in general it's similar.

@ikoruk ikoruk closed this Jul 29, 2024
@ikoruk
Copy link
Contributor Author

ikoruk commented Jul 29, 2024

This MP: https://code.launchpad.net/~yuliys/launchpad/+git/launchpad/+merge/470244 would fix the issue automatically, so I am closing this issue.

@ikoruk
Copy link
Contributor Author

ikoruk commented Jul 31, 2024

Reopening because it seems to work in a GCP ARM instance

@ikoruk ikoruk reopened this Jul 31, 2024
@ikoruk ikoruk requested a review from lgp171188 July 31, 2024 08:41
@ikoruk
Add fix for pynacl to "Setting up and running Launchpad"
c61134c 
* doc: update running launchpad how-to with pynacl fix for arm64
@ikoruk ikoruk requested a review from ineesalmeida July 31, 2024 11:14
ineesalmeida
ineesalmeida approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@ineesalmeida ineesalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

how-to/running.rst

.. code-block:: shell-session

$ sudo apt install --yes libsodium-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually tend to not add the -y flag in these commands to make it more of a conscious decision that users install an extra package, but that's a nit

@ikoruk ikoruk merged commit f979bc9 into canonical:main Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ineesalmeida ineesalmeida ineesalmeida approved these changes

@lgp171188 lgp171188 Awaiting requested review from lgp171188

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikoruk @lgp171188 @ineesalmeida