-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for pynacl to "Setting up and running Launchpad" #93
Conversation
ikoruk
commented
Jul 26, 2024
- doc: update running launchpad how-to with pynacl fix for arm64
Please tell me if you think I should also add another page in this PR for running in a Docker container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice to see these troubleshooting sections growing!
About the docker topic:
I think a page about how to run launchpad in a docker container seems interesting.
Out of curiosity, did you feel like the setup steps are simpler, or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment about using a vendored sdist of PyNaCl.
I based it on Clint's Dockerfile which has a few more steps than the documentation. But in general it's similar. |
This MP: https://code.launchpad.net/~yuliys/launchpad/+git/launchpad/+merge/470244 would fix the issue automatically, so I am closing this issue. |
Reopening because it seems to work in a GCP ARM instance |
* doc: update running launchpad how-to with pynacl fix for arm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
.. code-block:: shell-session | ||
|
||
$ sudo apt install --yes libsodium-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually tend to not add the -y
flag in these commands to make it more of a conscious decision that users install an extra package, but that's a nit