Skip to content

Commit

Permalink
Merge branch 'main' into spelling-feature-flags-doc
Browse files Browse the repository at this point in the history
  • Loading branch information
gerryRcom authored Jul 9, 2024
2 parents 1c6506b + 3e12837 commit 7a96001
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .custom_wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ mboxMailer
memcache
MemCache
milestoneoverlay
minified
minifies
minify
minimize
MockIo
mockups
Expand All @@ -229,6 +232,7 @@ mozilla
natively
newsampledata
NPM
OAuth
OEM
oid
Expand Down
2 changes: 1 addition & 1 deletion .sphinx/spellingcheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ matrix:
- .custom_wordlist.txt
output: .sphinx/.wordlist.dic
sources:
- _build/**/*.html|!_build/explanation/launchpad-ppa/index.html|!_build/explanation/branches/index.html|!_build/explanation/code/index.html|!_build/explanation/security-policy/index.html|!_build/explanation/database-performance/index.html|!_build/explanation/url-traversal/index.html|!_build/explanation/navigation-menus/index.html|!_build/explanation/storm-migration-guide/index.html|!_build/explanation/mail/index.html|!_build/explanation/javascript-buildsystem/index.html
- _build/**/*.html|!_build/explanation/launchpad-ppa/index.html|!_build/explanation/branches/index.html|!_build/explanation/code/index.html|!_build/explanation/security-policy/index.html|!_build/explanation/database-performance/index.html|!_build/explanation/url-traversal/index.html|!_build/explanation/navigation-menus/index.html|!_build/explanation/storm-migration-guide/index.html|!_build/explanation/mail/index.html
pipeline:
- pyspelling.filters.html:
comments: false
Expand Down
9 changes: 5 additions & 4 deletions explanation/javascript-buildsystem.rst
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ Adding a third-party widget
~~~~~~~~~~~~~~~~~~~~~~~~~~~

The current story for adding a third-party widget is to put it in
``lib/lp/contrib``. You can read the mailing list discussion (
https://lists.launchpad.net/launchpad-dev/msg06474.html ) about the adoption of
``lib/lp/contrib``. You can read the `mailing list discussion`_ about the adoption of
this location.

For CSS, follow the rules above to modify the tools. If other assets are
Expand All @@ -44,6 +43,8 @@ needed, you'll need to create a link in
``lib/lp/contrib`` so the assets can be found. See
``lib/canonical/launchpad/icing/yui3-gallery`` for an example.

.. _`mailing list discussion`: https://lists.launchpad.net/launchpad-dev/msg06474.html

New Combo loader Setup
----------------------

Expand All @@ -54,7 +55,7 @@ minified into a build directory ``build/js/``.
Files are served out of the ``build/js`` directory based on the YUI
combo loader config that is constructed in the
``lib/lp/app/templates/base-layout-macros.pt``. These are combined and
served out via the convoy wsgi application through Apache.
served out via the convoy WSGI application through Apache.

Developing Javascript
~~~~~~~~~~~~~~~~~~~~~
Expand Down Expand Up @@ -85,7 +86,7 @@ include that module name in any YUI block.
LPJS.use('modulename', function (Y)...
The combo loader will serve your new module when you reload the page
ith that content on it.
with that content on it.

Launchpad CSS
-------------
Expand Down

0 comments on commit 7a96001

Please sign in to comment.