Skip to content

Commit

Permalink
fix: resolve review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tushar5526 committed Aug 21, 2024
1 parent 9840502 commit 4dc05d9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion custom_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
'attachment:TranslationsSchema.dia', # needs update
r'https://github\.com/canonical/fetch-service*', # private
r'https://github\.com/canonical/fetch-operator*', # private
'https://git.launchpad.net/charm-launchpad-buildd-image-modifier/tree/files/scripts/setup-ppa-buildd' # private
'https://git.launchpad.net/charm-launchpad-buildd-image-modifier/tree/files/scripts/setup-ppa-buildd', # private
]

# Pages on which to ignore anchors
Expand Down
1 change: 1 addition & 0 deletions how-to/operating-launchpad.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ Operating Launchpad
transfer-project-ownership
create-bot-account
porting-builders-to-newer-ubuntu-versions

4 changes: 2 additions & 2 deletions how-to/porting-builders-to-newer-ubuntu-versions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ There are following steps to porting builders to newer Ubuntu versions.
Notes & Helpful links
---------------------

- With Ubuntu Noble, ``lxd`` is no longer a part of the base image and is pre-baked. Refer this `MP <https://code.launchpad.net/~tushar5526/charm-launchpad-buildd-image-modifier/+git/charm-launchpad-buildd-image-modifier/+merge/471494>`_ that pre-bakes ``lxd`` if not available. `launchpad-buildd <https://code.launchpad.net/~launchpad/launchpad-buildd/>`_ uses ``lxd`` to run builds.
- With Ubuntu Noble, ``lxd`` is no longer a part of the base image and is pre-baked. Refer this `commit <https://git.launchpad.net/charm-launchpad-buildd-image-modifier/commit/?id=e0ea7d79767c09412e9fd16855e0d5f1810fe357`>_ that pre-bakes ``lxd`` if not available. `launchpad-buildd <https://code.launchpad.net/~launchpad/launchpad-buildd/>`_ uses ``lxd`` to run builds.

- `Setting up a user on QA staging <https://documentation.ubuntu.com/launchpad/en/latest/how-to/manage-users>`_

- `Debugging build farms <https://documentation.ubuntu.com/launchpad/en/latest/how-to/debug-buildfarm-builder/>`_

- Charms can also be manually upgrade for a unit via:
- Charms can also be manually upgraded for a unit via:

.. code-block:: sh
Expand Down

0 comments on commit 4dc05d9

Please sign in to comment.