Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker plugin test #97

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Add Docker plugin test #97

merged 3 commits into from
Jan 23, 2024

Conversation

gtrkiller
Copy link
Contributor

Applicable spec:

Overview

Add an integration test for the docker-build-publish plugin.

Rationale

We need to keep track of plugin functionality when updating the charm

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

N/A

Checklist

Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Test coverage for 5a37e20

Name               Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------
src/actions.py        29      0      4      0   100%
src/agent.py          93      0     12      0   100%
src/charm.py          88      0     14      0   100%
src/cos.py            21      0      0      0   100%
src/ingress.py         9      0      0      0   100%
src/jenkins.py       336      0     60      0   100%
src/state.py         107      0     24      0   100%
src/timerange.py      31      0      6      0   100%
--------------------------------------------------------------
TOTAL                714      0    120      0   100%

Static code analysis report

Run started:2024-01-23 14:30:57.388949

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5667
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@gtrkiller gtrkiller merged commit 0b47ddd into main Jan 23, 2024
25 checks passed
@gtrkiller gtrkiller deleted the docker_plugin branch January 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants