Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Grafana-agent-k8s charm passes all traces to the tracing backend as it doesn't have any downsampling configuration.
Solution
Add a sampling policy with three config variables, setting up sampling strategies for charm traces, workload traces and errors.
Context
Grafana agent uses tail sampling processor from opentelemetry-collector, its reference is here: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.96.0/processor/tailsamplingprocessor
Testing Instructions
Run the following bundles:
Cos-lite + tempo model:
Grafana-agent model:
You can configure
charm_traces_sampling_percentage
,workload_traces_sampling_percentage
,error_traces_sampling_percentage
viajuju config grafana-agent-k8s ...
Upgrade Notes