feat: add machine Power On/Off Operations #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin120
force-pushed
the
machine-power-on-off-operation
branch
from
3cffc99
to
9948340
Compare
sachin120
changed the title
skatsaounis
changed the title
sachin120
force-pushed
the
machine-power-on-off-operation
branch
from
9948340
to
911ebba
Compare
skatsaounis
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Hi @sachin120 and thank you for your contribution. It seems that both power on and off operations can accept optional arguments as per https://maas.io/docs/api. Could you please update your PR to include them?
- In case of power on user can provide a
commentanduser_datain the format of base64 string. - In case of power off user can provide a
commentandstop_mode
skatsaounis
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue: #37 (comment)
What dose this implement
Added support for Machine Power On/Off operations