-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish implementation of connection to multiple cluster with relation aliases #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one blocking (to me) comment. Want to see more comments on that.
All the rest and tests looks good though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of minor nits about style but this looks really solid :)
Issue
In short this PR address JIRA ticket DPE-423.
In long:
Solution
Context
DatabaseRequires
class:relations_aliases
attribute that store the relations/clusters aliases and is used to create the custom events names for each relation/cluster._assign_relation_alias
method: used to assign an alias to a relation instance afterjuju relate
is called._emit_custom_event
method: used to emit a custom event for a specific relation/cluster._get_relation_alias
method: used to get the alias of a relation instance.Testing
Release Notes