[DPE-3325] Dynamically adding Peer Data Secrets (groped on-demand) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
force-pushed
the
DPE-3325_multi_secrets_dynamic_update
branch
5 times, most recently
from
514b74e
to
876f7ba
Compare
juditnovak
force-pushed
the
DPE-3325_multi_secrets_dynamic_update
branch
from
ac43cce
to
8c17173
Compare
juditnovak
force-pushed
the
DPE-3325_multi_secrets_dynamic_update
branch
from
8c17173
to
f500c1a
Compare
juditnovak
force-pushed
the
DPE-3325_multi_secrets_dynamic_update
branch
from
f500c1a
to
f467156
Compare
juditnovak
changed the title
delgod
requested changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most charms use a single secret on
app, and another one onunitlevel. Therefore this was the functionality provided by theDataPeerand theDataPeerUnitinterfaces.This change is extending that behavior to what is only used by a few charms (Opensearch, Pgbouncer) allowing for multiple secrets on either level. The implemetation goes in a way, that new secret fields can also form new groups or be saved into an individual secret labelled after the key.