-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Pro status in managed LXD instance #652
Get Pro status in managed LXD instance #652
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pro-sources #652 +/- ##
======================================================
Coverage ? 98.88%
======================================================
Files ? 54
Lines ? 4478
Branches ? 0
======================================================
Hits ? 4428
Misses ? 50
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@canonical/starcraft-reviewers This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add integration tests to this that check it with, say, Ubuntu Noble and Alma Linux 9?
@lengau We don't have spread tests in craft-providers. Perhaps we can do such tests in rockcraft once all those pro PRs are merged? |
@linostar I'm requesting an integration test like the ones here: https://github.com/canonical/craft-providers/blob/main/tests/integration/lxd/test_lxc.py It would create an instance and run these functions on that instance. |
7412faa
to
a489fa7
Compare
a489fa7
to
773506b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @linostar , this looks good to me!
tox
?