Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip typing checkers in "_version.py" #404

Merged
merged 3 commits into from
Sep 21, 2023
Merged

chore: skip typing checkers in "_version.py" #404

merged 3 commits into from
Sep 21, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Ignore _version.py (similar to canonical/craft-application#82).

Hidden and pycache files must to be explicitly excluded once the exclude keyword is used. (see the pyright documentation)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #404 (d1a37ac) into main (91fc208) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          57       57           
  Lines        4454     4454           
=======================================
  Hits         4409     4409           
  Misses         45       45           

Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal merged commit 371d77c into main Sep 21, 2023
12 of 13 checks passed
@mr-cal mr-cal deleted the pyright-exclude branch September 21, 2023 22:18
@mr-cal mr-cal mentioned this pull request Sep 22, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants