Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: create craft_providers_docs package #348

Merged
merged 5 commits into from
Jul 5, 2023
Merged

pkg: create craft_providers_docs package #348

merged 5 commits into from
Jul 5, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jul 3, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Sadly with a pyproject.toml we can either use setuptools.find or we can create package namespaces that don't correspond with a directory. This shouldn't be a big issue for us though.

CRAFT-1799

macos test failure due to: Homebrew/brew#15621

Signed-off-by: Callahan Kovacs <[email protected]>
@lengau lengau marked this pull request as draft July 3, 2023 21:27
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #348 (a02412d) into main (889a2cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          56       56           
  Lines        4303     4303           
=======================================
  Hits         4255     4255           
  Misses         48       48           

@lengau lengau marked this pull request as ready for review July 4, 2023 01:12
@lengau lengau requested a review from mr-cal July 4, 2023 01:12
@mr-cal mr-cal merged commit 86118c4 into main Jul 5, 2023
12 checks passed
@mr-cal mr-cal deleted the aml/providers-docs branch July 5, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants