Skip to content

Commit

Permalink
chore: remove kinetic (#402)
Browse files Browse the repository at this point in the history
Ubuntu 22.10 (kinetic) is an interim release and has reached
end of life.

Signed-off-by: Callahan Kovacs <[email protected]>
Co-authored-by: Tiago Nobrega <[email protected]>
  • Loading branch information
mr-cal and tigarmo authored Sep 19, 2023
1 parent c9ba62b commit 4c400b1
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 18 deletions.
1 change: 0 additions & 1 deletion craft_providers/bases/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class BaseName(NamedTuple):
BaseName("ubuntu", "18.04"): ubuntu.BuilddBaseAlias.BIONIC,
BaseName("ubuntu", "20.04"): ubuntu.BuilddBaseAlias.FOCAL,
BaseName("ubuntu", "22.04"): ubuntu.BuilddBaseAlias.JAMMY,
BaseName("ubuntu", "22.10"): ubuntu.BuilddBaseAlias.KINETIC,
BaseName("ubuntu", "23.04"): ubuntu.BuilddBaseAlias.LUNAR,
BaseName("ubuntu", "devel"): ubuntu.BuilddBaseAlias.DEVEL,
BaseName("centos", "7"): centos.CentOSBaseAlias.SEVEN,
Expand Down
1 change: 0 additions & 1 deletion craft_providers/bases/ubuntu.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class BuilddBaseAlias(enum.Enum):
BIONIC = "18.04"
FOCAL = "20.04"
JAMMY = "22.04"
KINETIC = "22.10"
LUNAR = "23.04"
DEVEL = "devel"

Expand Down
8 changes: 1 addition & 7 deletions craft_providers/lxd/remotes.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
BUILDD_RELEASES_REMOTE_NAME = "craft-com.ubuntu.cloud-buildd"
BUILDD_RELEASES_REMOTE_ADDRESS = "https://cloud-images.ubuntu.com/buildd/releases"

# XXX: lunar and kinetic buildd daily images are not working (LP #2007419)
# XXX: lunar buildd daily images are not working (LP #2007419)
BUILDD_DAILY_REMOTE_NAME = "craft-com.ubuntu.cloud-buildd-daily"
BUILDD_DAILY_REMOTE_ADDRESS = "https://cloud-images.ubuntu.com/buildd/daily"

Expand Down Expand Up @@ -144,12 +144,6 @@ def add_remote(self, lxc: LXC) -> None:
remote_address=BUILDD_RELEASES_REMOTE_ADDRESS,
remote_protocol=ProtocolType.SIMPLESTREAMS,
),
ubuntu.BuilddBaseAlias.KINETIC: RemoteImage(
image_name="kinetic",
remote_name=DAILY_REMOTE_NAME,
remote_address=DAILY_REMOTE_ADDRESS,
remote_protocol=ProtocolType.SIMPLESTREAMS,
),
ubuntu.BuilddBaseAlias.LUNAR: RemoteImage(
image_name="lunar",
remote_name=DAILY_REMOTE_NAME,
Expand Down
4 changes: 0 additions & 4 deletions craft_providers/multipass/multipass_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ def name(self) -> str:
ubuntu.BuilddBaseAlias.JAMMY: RemoteImage(
remote=Remote.SNAPCRAFT, image_name="22.04"
),
# kinetic image is not available on macos
ubuntu.BuilddBaseAlias.KINETIC: RemoteImage(
remote=Remote.RELEASE, image_name="kinetic"
),
ubuntu.BuilddBaseAlias.LUNAR: RemoteImage(
remote=Remote.RELEASE, image_name="lunar"
),
Expand Down
3 changes: 0 additions & 3 deletions tests/integration/multipass/test_multipass_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ def test_create_environment(installed_multipass, instance_name):
def test_launched_environment(alias, installed_multipass, instance_name, tmp_path):
"""Verify `launched_environment()` creates and starts an instance then stops
the instance when the method loses context."""
if sys.platform == "darwin" and alias == BuilddBaseAlias.KINETIC:
pytest.skip(reason="previous interim releases are not available on MacOS")

if sys.platform == "darwin" and alias == BuilddBaseAlias.DEVEL:
pytest.skip(reason="snapcraft:devel is not working on MacOS (LP #2007419)")

Expand Down
2 changes: 0 additions & 2 deletions tests/unit/lxd/test_remotes.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ def test_add_remote_race_condition_error(fake_remote_image, mock_lxc, logs):
(ubuntu.BuilddBaseAlias.BIONIC, "core18"),
(ubuntu.BuilddBaseAlias.FOCAL, "core20"),
(ubuntu.BuilddBaseAlias.JAMMY, "core22"),
(ubuntu.BuilddBaseAlias.KINETIC, "kinetic"),
(ubuntu.BuilddBaseAlias.LUNAR, "lunar"),
(ubuntu.BuilddBaseAlias.DEVEL, "devel"),
],
Expand All @@ -164,7 +163,6 @@ def test_get_image_remote(provider_base_alias, image_name):
(ubuntu.BuilddBaseAlias.BIONIC, "core18"),
(ubuntu.BuilddBaseAlias.FOCAL, "core20"),
(ubuntu.BuilddBaseAlias.JAMMY, "core22"),
(ubuntu.BuilddBaseAlias.KINETIC, "kinetic"),
(ubuntu.BuilddBaseAlias.LUNAR, "lunar"),
(ubuntu.BuilddBaseAlias.DEVEL, "devel"),
],
Expand Down

0 comments on commit 4c400b1

Please sign in to comment.