fix(plugins): ensure stateless npm plugin #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushuyu
force-pushed
the
npm-plugin-hotfix
branch
from
eb09328
to
938a603
Compare
|
I think I can't fix the linter errors in this hotfix due to too many files affected. |
liushuyu
force-pushed
the
npm-plugin-hotfix
branch
from
938a603
to
d1a0df0
Compare
regression that caused builds to fail on Launchpad builders
liushuyu
force-pushed
the
npm-plugin-hotfix
branch
from
d1a0df0
to
e454283
Compare
|
I confirmed that with this fix the repro case linked in #844 builds locally |
tigarmo
approved these changes
Sep 13, 2024
mr-cal
approved these changes
Sep 13, 2024
cmatsuoka
approved these changes
Sep 13, 2024
cmatsuoka
changed the title
github-merge-queue bot
referenced
this pull request
in canonical/charmcraft
Sep 19, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cffi](http://cffi.readthedocs.org) ([source](https://redirect.github.com/python-cffi/cffi), [changelog](https://cffi.readthedocs.io/en/latest/whatsnew.html)) | `==1.17.0` -> `==1.17.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [craft-parts](https://redirect.github.com/canonical/craft-parts) | `==2.1.0` -> `==2.1.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | craft-providers | `==2.0.0` -> `==2.0.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [hypothesis](https://hypothesis.works) ([source](https://redirect.github.com/HypothesisWorks/hypothesis/tree/HEAD/hypothesis-python), [changelog](https://hypothesis.readthedocs.io/en/latest/changes.html)) | `==6.112.0` -> `==6.112.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pylint](https://redirect.github.com/pylint-dev/pylint) ([changelog](https://pylint.readthedocs.io/en/latest/whatsnew/3/)) | `==3.2.6` -> `==3.2.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pytest](https://redirect.github.com/pytest-dev/pytest) ([changelog](https://docs.pytest.org/en/stable/changelog.html)) | `==8.3.2` -> `==8.3.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [zipp](https://redirect.github.com/jaraco/zipp) | `==3.20.1` -> `==3.20.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>python-cffi/cffi (cffi)</summary> ### [`v1.17.1`](https://redirect.github.com/python-cffi/cffi/releases/tag/v1.17.1) [Compare Source](https://redirect.github.com/python-cffi/cffi/compare/v1.17.0...v1.17.1) - Fix failing `distutils.msvc9compiler` imports under Windows ([#​118](https://redirect.github.com/python-cffi/cffi/issues/118)). - `ffibuilder.emit_python_code()` and `ffibuiler.emit_c_code()` accept file-like objects ([#​115](https://redirect.github.com/python-cffi/cffi/issues/115)). - `ffiplatform` calls are bypassed by `ffibuilder.emit_python_code()` and `ffibuilder.emit_c_code()` ([#​81](https://redirect.github.com/python-cffi/cffi/issues/81)). **Full Changelog**: python-cffi/cffi@v1.17.0...v1.17.1 </details> <details> <summary>canonical/craft-parts (craft-parts)</summary> ### [`v2.1.1`](https://redirect.github.com/canonical/craft-parts/releases/tag/2.1.1) [Compare Source](https://redirect.github.com/canonical/craft-parts/compare/2.1.0...2.1.1) ##### What's Changed - minor format and cherry-picked fixes for 1.33.x by [@​tigarmo](https://redirect.github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/846](https://redirect.github.com/canonical/craft-parts/pull/846) - fix(plugins): ensure stateless npm plugin by [@​liushuyu](https://redirect.github.com/liushuyu) in [https://github.com/canonical/craft-parts/pull/845](https://redirect.github.com/canonical/craft-parts/pull/845) - Release 1.33.1 by [@​cmatsuoka](https://redirect.github.com/cmatsuoka) in [https://github.com/canonical/craft-parts/pull/847](https://redirect.github.com/canonical/craft-parts/pull/847) - chore(merge): 'merge-1.33.1' into 'main' by [@​tigarmo](https://redirect.github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/848](https://redirect.github.com/canonical/craft-parts/pull/848) - Prepare 2.1.1 release by [@​tigarmo](https://redirect.github.com/tigarmo) in [https://github.com/canonical/craft-parts/pull/849](https://redirect.github.com/canonical/craft-parts/pull/849) **Full Changelog**: canonical/craft-parts@2.1.0...2.1.1 </details> <details> <summary>pylint-dev/pylint (pylint)</summary> ### [`v3.2.7`](https://redirect.github.com/pylint-dev/pylint/releases/tag/v3.2.7) [Compare Source](https://redirect.github.com/pylint-dev/pylint/compare/v3.2.6...v3.2.7) ## What's new in Pylint 3.2.7? Release date: 2024-08-31 ## False Positives Fixed - Fixed a false positive `unreachable` for `NoReturn` coroutine functions. Closes [#​9840](https://redirect.github.com/pylint-dev/pylint/issues/9840) ## Other Bug Fixes - Fix crash in refactoring checker when calling a lambda bound as a method. Closes [#​9865](https://redirect.github.com/pylint-dev/pylint/issues/9865) - Fix a crash in `undefined-loop-variable` when providing the `iterable` argument to `enumerate()`. Closes [#​9875](https://redirect.github.com/pylint-dev/pylint/issues/9875) - Fix to address indeterminacy of error message in case a module name is same as another in a separate namespace. Refs [#​9883](https://redirect.github.com/pylint-dev/pylint/issues/9883) </details> <details> <summary>pytest-dev/pytest (pytest)</summary> ### [`v8.3.3`](https://redirect.github.com/pytest-dev/pytest/releases/tag/8.3.3) [Compare Source](https://redirect.github.com/pytest-dev/pytest/compare/8.3.2...8.3.3) # pytest 8.3.3 (2024-09-09) ## Bug fixes - [#​12446](https://redirect.github.com/pytest-dev/pytest/issues/12446): Avoid calling `@property` (and other instance descriptors) during fixture discovery -- by `asottile`{.interpreted-text role="user"} - [#​12659](https://redirect.github.com/pytest-dev/pytest/issues/12659): Fixed the issue of not displaying assertion failure differences when using the parameter `--import-mode=importlib` in pytest>=8.1. - [#​12667](https://redirect.github.com/pytest-dev/pytest/issues/12667): Fixed a regression where type change in \[ExceptionInfo.errisinstance]{.title-ref} caused \[mypy]{.title-ref} to fail. - [#​12744](https://redirect.github.com/pytest-dev/pytest/issues/12744): Fixed typing compatibility with Python 3.9 or less -- replaced \[typing.Self]{.title-ref} with \[typing_extensions.Self]{.title-ref} -- by `Avasam`{.interpreted-text role="user"} - [#​12745](https://redirect.github.com/pytest-dev/pytest/issues/12745): Fixed an issue with backslashes being incorrectly converted in nodeid paths on Windows, ensuring consistent path handling across environments. - [#​6682](https://redirect.github.com/pytest-dev/pytest/issues/6682): Fixed bug where the verbosity levels where not being respected when printing the "msg" part of failed assertion (as in `assert condition, msg`). - [#​9422](https://redirect.github.com/pytest-dev/pytest/issues/9422): Fix bug where disabling the terminal plugin via `-p no:terminal` would cause crashes related to missing the `verbose` option. \-- by `GTowers1`{.interpreted-text role="user"} ## Improved documentation - [#​12663](https://redirect.github.com/pytest-dev/pytest/issues/12663): Clarify that the \[pytest_deselected]{.title-ref} hook should be called from \[pytest_collection_modifyitems]{.title-ref} hook implementations when items are deselected. - [#​12678](https://redirect.github.com/pytest-dev/pytest/issues/12678): Remove erroneous quotes from \[tmp_path_retention_policy]{.title-ref} example in docs. ## Miscellaneous internal changes - [#​12769](https://redirect.github.com/pytest-dev/pytest/issues/12769): Fix typos discovered by codespell and add codespell to pre-commit hooks. </details> <details> <summary>jaraco/zipp (zipp)</summary> ### [`v3.20.2`](https://redirect.github.com/jaraco/zipp/compare/v3.20.1...v3.20.2) [Compare Source](https://redirect.github.com/jaraco/zipp/compare/v3.20.1...v3.20.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request works around an issue that regressed NPM-based projects on the Launchpad auto-build system.
The issue was that the Launchpad auto-build system executed pull and build steps separately, thereby losing the shared state between them.
This is a temporary fix for the 1.33 branch.