feat(partitions): custom error for nonexistent partition #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
reviewed
Aug 29, 2024
mr-cal
approved these changes
Aug 29, 2024
Co-authored-by: Alex Lowe <[email protected]>
|
Linters are failing because cmake.org is down right now. |
lengau
approved these changes
Aug 29, 2024
tigarmo
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a custom error when a nonexistent partition is asked for, so
corncraftcan catch it more cleanly.Depending on the stringification is fragile, but if you don't do some sort of deeper check then you could accidentally handle other
ValueErrors.(CRAFT-3031)