Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sources: add an rpm source handler #377

Merged
merged 13 commits into from
Mar 3, 2023
Merged

sources: add an rpm source handler #377

merged 13 commits into from
Mar 3, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Feb 23, 2023

  • Have you signed the CLA?

CRAFT-1583

@lengau lengau requested review from tigarmo and cmatsuoka and removed request for tigarmo March 1, 2023 05:56
tigarmo
tigarmo approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ;)

craft_parts/sources/errors.py Show resolved Hide resolved
tests/integration/sources/test_rpm.py Outdated Show resolved Hide resolved
tests/integration/sources/test_rpm.py Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
@lengau lengau requested a review from tigarmo March 2, 2023 23:08
cmatsuoka
cmatsuoka approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex it looks great. Just add a comment explaining the decision of not using rpm2cpio, otherwise someone could change it in the future.

@cmatsuoka cmatsuoka enabled auto-merge (squash) March 3, 2023 00:39
@cmatsuoka cmatsuoka merged commit 7775681 into canonical:main Mar 3, 2023
@lengau lengau deleted the CRAFT-1583 branch March 3, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens left review comments

@cmatsuoka cmatsuoka cmatsuoka approved these changes

@tigarmo tigarmo Awaiting requested review from tigarmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lengau @cmatsuoka @sergiusens @tigarmo