Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROCK for contour #1

Merged
merged 11 commits into from
Jul 19, 2024
Merged

ROCK for contour #1

merged 11 commits into from
Jul 19, 2024

Conversation

maci3jka
Copy link
Collaborator

@maci3jka maci3jka commented Jul 8, 2024

KU-1063

@maci3jka maci3jka requested review from berkayoz, bschimke95 and a team July 8, 2024 09:05
bschimke95
bschimke95 reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the tests in a separate PR and use the k8s-test-harness

@maci3jka maci3jka requested a review from bschimke95 July 19, 2024 08:48
berkayoz
berkayoz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berkayoz berkayoz merged commit 47c5a19 into main Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkayoz berkayoz berkayoz approved these changes

@bschimke95 bschimke95 Awaiting requested review from bschimke95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maci3jka @berkayoz @bschimke95