Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hypervisor Upgrade #379

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Fix Hypervisor Upgrade #379

merged 7 commits into from
Apr 22, 2024

Conversation

gabrielcocenza
Copy link
Member

  • HypervisorUpgradePlan was wrongly running steps on parallel which caused to change openstack-origin or source at the same time of action-managed-upgrade. This could wrongly trigger the upgrade on all units.
  • added the Psi (Ψ) to user vizualize which steps are going to run on parallel
  • updated docs

@gabrielcocenza
Fix Hypervisor Upgrade
ac3f674 
- HypervisorUpgradePlan was wrongly running steps on parallel which
  caused to change openstack-origin or source at the same time of
  action-managed-upgrade. This could wrongly trigger the upgrade
  on all units.
- added the Psi (Ψ) to user vizualize which steps are going to run
  on parallel
- updated docs
@gabrielcocenza gabrielcocenza added bug Something isn't working high labels Apr 18, 2024
@gabrielcocenza gabrielcocenza self-assigned this Apr 18, 2024
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner April 18, 2024 20:30
aieri
aieri requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, just some documentation suggestions

cou/steps/__init__.py Show resolved Hide resolved
docs/explanation/planning.rst Outdated Show resolved Hide resolved
rgildein
rgildein requested changes Apr 19, 2024
View reviewed changes
cou/steps/__init__.py Outdated Show resolved Hide resolved
tests/unit/steps/test_steps.py Outdated Show resolved Hide resolved
@gabrielcocenza
- apply suggestions
4cd3dd1 
- change the names on sub-steps of parallel steps to be sequential,
  because it can be misleading once they will run sequentially.
aieri
aieri previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just non-blocking suggestions at this point

cou/steps/__init__.py Outdated Show resolved Hide resolved
cou/steps/__init__.py Outdated Show resolved Hide resolved
rgildein
rgildein previously approved these changes Apr 22, 2024
View reviewed changes
@gabrielcocenza gabrielcocenza dismissed stale reviews from rgildein and aieri via 310634e April 22, 2024 13:16
@gabrielcocenza gabrielcocenza merged commit 857ddaf into canonical:main Apr 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aieri aieri aieri approved these changes

@rgildein rgildein rgildein approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@gabrielcocenza gabrielcocenza

Labels
bug Something isn't working high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielcocenza @aieri @rgildein