Add log with OS app string representation to Analysis._populate #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, we can collect info about application during Analysis._populate, like this the log will contain the app string representation before planning. log message example: ```bash found OpenStack application: app-name: model_name: <model-name> ... ```
aieri
reviewed
Apr 10, 2024
cou/steps/analyze.py
Outdated
| for name, app in juju_applications.items(): | ||
| if os_app := AppFactory.create(app): | ||
| apps.add(os_app) | ||
| logger.info("found OpenStack application:\n%s", os_app) |
There was a problem hiding this comment.
Suggested change
| logger.info("found OpenStack application:\n%s", os_app) | |
| logger.info("Found OpenStack application:\n%s", os_app) |
agileshaw
suggested changes
Apr 10, 2024
|
|
||
| # remove non-supported charms that return None on AppFactory.create | ||
| apps.discard(None) | ||
| # mypy complains that apps can have None, but we already removed. |
There was a problem hiding this comment.
we need to remove this comment too
| } | ||
| other_o7k_apps = apps - apps_to_upgrade_in_order | ||
| sorted_apps_to_upgrade_in_order = sorted( | ||
| apps_to_upgrade_in_order, | ||
| key=lambda app: UPGRADE_ORDER.index(app.charm), # type: ignore | ||
| key=lambda app: UPGRADE_ORDER.index(app.charm), | ||
| ) | ||
| # order by charm name to have a predictable upgrade sequence of others o7k charms. |
There was a problem hiding this comment.
Suggested change
| # order by charm name to have a predictable upgrade sequence of others o7k charms. | |
| # order by charm name to have a predictable upgrade sequence of other o7k charms. |
|
superseded by #371 |
rgildein
pushed a commit
that referenced
this pull request
Apr 10, 2024
With this, we can collect info about application during Analysis._populate, like this the log will contain the app string representation before planning. log message example: ``` found OpenStack application: app-name: model_name: <model-name> ... ``` This PR supersedes #368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we can collect info about application during Analysis._populate, like this the log will contain the app string representation before planning.
log message example: