Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env for idle timeout #293

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

rgildein
Copy link
Contributor

Add env variables for configuring the idle period of step waiting for app or model to be in idle state.

@rgildein rgildein added the enhancement New feature or request label Mar 12, 2024
@rgildein rgildein self-assigned this Mar 12, 2024
@rgildein rgildein requested a review from a team as a code owner March 12, 2024 14:26
@rgildein rgildein force-pushed the feature/BSENG-2163/add-idle-timeout branch from 6238f6a to 95c07b7 Compare March 12, 2024 15:43
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add the env variable description to README?

@rgildein rgildein requested a review from agileshaw March 13, 2024 11:32
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rgildein rgildein requested a review from a team as a code owner March 15, 2024 09:25
@rgildein rgildein added the high label Mar 15, 2024
@rgildein rgildein merged commit 690abf6 into canonical:main Mar 15, 2024
5 checks passed
@rgildein rgildein deleted the feature/BSENG-2163/add-idle-timeout branch March 15, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants