-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data-plane pre upgrade sanity checks #222
Merged
rgildein
merged 11 commits into
canonical:dev/data-plane
from
gabrielcocenza:pre_plan_sane_check
Jan 24, 2024
Merged
Add data-plane pre upgrade sanity checks #222
rgildein
merged 11 commits into
canonical:dev/data-plane
from
gabrielcocenza:pre_plan_sane_check
Jan 24, 2024
Commits on Jan 16, 2024
-
- create a new NamedTuple class to be the COU Namespace. With that, type is still checked and few arguments are necessary to pass to the functions that use the arguments passed by the user. Moreover, docstrings are shorter and easier to maintain - Global variables for "data-plane" and "control-plane".
Configuration menu - View commit details
-
Copy full SHA for f66362a - Browse repository at this point
Copy the full SHA f66362aView commit details -
Add data-plane pre upgrade sane checks
- check if control-plane is already upgraded if user pass "data-pane" upgrade group - check if data-plane apps exists if user pass "data-pane" upgrade group - splitted the logic on determine_upgrade_target to several functions
Configuration menu - View commit details
-
Copy full SHA for b8f0e58 - Browse repository at this point
Copy the full SHA b8f0e58View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fdb598e - Browse repository at this point
Copy the full SHA fdb598eView commit details -
- change from Namespace to CLIargs
- fixed run_upgrade unit test
Configuration menu - View commit details
-
Copy full SHA for 5d04a32 - Browse repository at this point
Copy the full SHA 5d04a32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 672496b - Browse repository at this point
Copy the full SHA 672496bView commit details -
- added is_data_plane_command property on CLIargs
- added expected error messages on the remaining sanaity checks unit tests.
Configuration menu - View commit details
-
Copy full SHA for 4d5e94c - Browse repository at this point
Copy the full SHA 4d5e94cView commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a0cac77 - Browse repository at this point
Copy the full SHA a0cac77View commit details -
Configuration menu - View commit details
-
Copy full SHA for d861643 - Browse repository at this point
Copy the full SHA d861643View commit details -
Configuration menu - View commit details
-
Copy full SHA for a364440 - Browse repository at this point
Copy the full SHA a364440View commit details
Commits on Jan 19, 2024
-
- small change in is_highest_release_achieved function
Configuration menu - View commit details
-
Copy full SHA for b98d1a4 - Browse repository at this point
Copy the full SHA b98d1a4View commit details
Commits on Jan 23, 2024
-
- changed from is_* to verify_* because it seems that will return
a boolean. - removed the pre_plan_sanity_checks is_valid_openstack_cloud to be nested under determine_upgrade_target - fixed unit tests to test the verify_* functions instead of the pre_plan_sanity_checks
Configuration menu - View commit details
-
Copy full SHA for a9ee8ed - Browse repository at this point
Copy the full SHA a9ee8edView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.