Custom COU Namespace #221
Merged
Custom COU Namespace #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a new NamedTuple class to be the COU Namespace. With that, type is still checked and few arguments are necessary to pass to the functions that use the arguments passed by the user. Moreover, docstrings are shorter and easier to maintain - Global variables for "data-plane" and "control-plane".
gabrielcocenza
requested review from
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
rgildein
requested changes
Jan 17, 2024
- fixed run_upgrade unit test
agileshaw
reviewed
Jan 18, 2024
rgildein
approved these changes
Jan 18, 2024
agileshaw
approved these changes
Jan 18, 2024
rgildein
pushed a commit
that referenced
this pull request
Jan 24, 2024
- check if control-plane is already upgraded if user pass "data-pane" upgrade group - check if data-plane apps exists if user pass "data-pane" upgrade group - splitted the logic on determine_upgrade_target to several functions This PR should be merged after #221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a new NamedTuple class to be the COU Namespace. With that, type is still checked and few arguments are necessary to pass to the functions that use the arguments passed by the user. Moreover, docstrings are shorter and easier to maintain
Global variables for "data-plane" and "control-plane".