add UnitUpgradeStep, improve add_step #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UnitUpgradeStep and is_unit_upgrade_step, also use sub_steps as property to prevent defining it as not list of BaseStep's. Raising TypeError in add_step if object is not based on BaseStep.
agileshaw
suggested changes
Jan 18, 2024
agileshaw
approved these changes
Jan 23, 2024
gabrielcocenza
approved these changes
Jan 23, 2024
rgildein
added a commit
to rgildein/charmed-openstack-upgrader
that referenced
this pull request
Feb 7, 2024
Add UnitUpgradeStep and is_unit_upgrade_step, also use sub_steps as property to prevent defining it as not list of BaseStep's. Raising TypeError in add_step if object is not based on BaseStep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UnitUpgradeStep and is_unit_upgrade_step, also use sub_steps as property to prevent defining it as not list of BaseStep's. Raising TypeError in add_step if object is not based on BaseStep.