Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop smoke tests #217

Merged
merged 3 commits into from
Jan 18, 2024
Merged

drop smoke tests #217

merged 3 commits into from
Jan 18, 2024

Conversation

rgildein
Copy link
Contributor

After we decided to drop small OpenStack bundle and run all tests again the smoke tests, there is no need to have smoke tests definition in tox or Makefile.

@rgildein
drop smoke tests
de8f1ca 
After we decided to drop small OpenStack bundle and run all tests again
the smoke tests, there is no need to have smoke tests definition in tox
or Makefile.
@rgildein rgildein added the enhancement New feature or request label Jan 15, 2024
@rgildein rgildein self-assigned this Jan 15, 2024
@rgildein rgildein requested a review from a team as a code owner January 15, 2024 13:18
agileshaw
agileshaw reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If we are dropping these smoke targets, I think we can also remove smoke_bundle in tests.yaml?

@rgildein
Copy link
Contributor Author

Looks good. If we are dropping these smoke targets, I think we can also remove smoke_bundle in tests.yaml?

We could 👍

@rgildein rgildein merged commit 123631b into canonical:main Jan 18, 2024
4 checks passed
@rgildein rgildein deleted the tests/drop-func-tests branch January 18, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agileshaw agileshaw agileshaw approved these changes

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack was automatically assigned from canonical/bootstack-reviewers

@aieri aieri Awaiting requested review from aieri aieri was automatically assigned from canonical/bootstack-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 was automatically assigned from canonical/bootstack-reviewers

Assignees

@rgildein rgildein

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgildein @agileshaw @gabrielcocenza