-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update images used in testing an airgapped CKF 1.9 deployment #1053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Noha Ihab <[email protected]>
Co-authored-by: Noha Ihab <[email protected]>
@kimwnasptd agreed, @mvlassis let's have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job @mvlassis 🚀
Closes #1051
Firstly, this PR creates separate directories for testing an airgapped deployment on CKF 1.8 and 1.9, under
tests/airgapped/1.8
andtests/airgapped/1.9
respectively.Additionally updates the manually retrieved images in
tests/airgapped/ckf-1.9-testing-images.txt
for CKF 1.9.The images are updated as follows:
charmedkubeflow/pipelines-runner:ckf-1.8
: Updated tocharmedkubeflow/pipelines-runner:ckf-1.9
that was created as part of this task.docker.io/kubeflowkatib/simple-pbt:v0.16.0
: Updated tov.0.17.0
that matches the Knative version used in CKF 1.9.ghcr.io/knative/helloworld-go:latest
: Kept the same, as it is still the same tag used in this tutorialgcr.io/kubeflow-ci/tf-mnist-with-summaries:1.0
: Updated tokubeflow/tf-mnist-with-summaries:latest
, similar to the images we used for the UATs, as seen here. I confirmed that this image can indeed run with the--fake-data
option we give, by running:A small addition is changing the default values (Juju
3.4
,ckf-1.9-testing-images.txt
) intests/airgapped/setup.sh
.