Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images used in testing an airgapped CKF 1.9 deployment #1053

Merged
merged 30 commits into from
Sep 9, 2024

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Sep 4, 2024

Closes #1051

Firstly, this PR creates separate directories for testing an airgapped deployment on CKF 1.8 and 1.9, under tests/airgapped/1.8 and tests/airgapped/1.9 respectively.

Additionally updates the manually retrieved images in tests/airgapped/ckf-1.9-testing-images.txt for CKF 1.9.

The images are updated as follows:

  • charmedkubeflow/pipelines-runner:ckf-1.8: Updated to charmedkubeflow/pipelines-runner:ckf-1.9 that was created as part of this task.
  • docker.io/kubeflowkatib/simple-pbt:v0.16.0: Updated to v.0.17.0 that matches the Knative version used in CKF 1.9.
  • ghcr.io/knative/helloworld-go:latest: Kept the same, as it is still the same tag used in this tutorial
  • gcr.io/kubeflow-ci/tf-mnist-with-summaries:1.0: Updated to kubeflow/tf-mnist-with-summaries:latest, similar to the images we used for the UATs, as seen here. I confirmed that this image can indeed run with the --fake-data option we give, by running:
docker run --rm kubeflow/tf-mnist-with-summaries:latest \
python /var/tf_mnist/mnist_with_summaries.py --fake_data=True

A small addition is changing the default values (Juju 3.4, ckf-1.9-testing-images.txt) in tests/airgapped/setup.sh.

@mvlassis mvlassis requested a review from a team as a code owner September 4, 2024 13:00
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mvlassis , left some comments.
Once #1038 is merged, let's also update tests/airgapped/README.md for 1.9

tests/airgapped/1.9/pipelines/pipelines-runner/Dockerfile Outdated Show resolved Hide resolved
tests/airgapped/1.9/pipelines/pipelines-runner/Dockerfile Outdated Show resolved Hide resolved
tests/airgapped/1.9/training/tfjob-simple.yaml Outdated Show resolved Hide resolved
tests/airgapped/1.9/training/README.md Outdated Show resolved Hide resolved
tests/airgapped/1.9/knative/helloworld.yaml Outdated Show resolved Hide resolved
@kimwnasptd
Copy link
Contributor

@mvlassis @NohaIhab now that #1036 is resolved, should we have dedicated files with the testing images needed for each release into the sub-folders introduced by this PR?

And then they could be used with the --append-images arg of the scripts/get-images.py script

@NohaIhab
Copy link
Contributor

NohaIhab commented Sep 9, 2024

@kimwnasptd agreed, @mvlassis let's have a testing-images.txt in the directory for each release as we are saying in the README

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job @mvlassis 🚀

@mvlassis mvlassis merged commit a0f25bf into main Sep 9, 2024
@mvlassis mvlassis deleted the kf-6200-update-airgapped-test-images branch September 9, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update images used for testing an airgapped CKF 1.9 deployment
3 participants