Fix network_interface_info module

[sugaf1204]

This module accepts only machine and mac_address parameter.
Network_interface_info module calls /MAAS/api/2.0/machines/ API with fqdn query parameter.
To transform machine to fqdn, specifing name_field_ansible opt.

ansible-collection/plugins/modules/network_interface_info.py

Line 136 in 7bb2a1b

machine_obj = Machine.get_by_fqdn(module, client, must_exist=True)

Checklist before merging

• Formatting: tox -e format
• Linting: tox -e sanity
• Unit tests: tox -e units

[sugaf1204]

@SK1Y101
Could you please check this PR?

[github-actions]

Everyone contributing to this PR have now signed the CLA. Thanks!

[SK1Y101]

Hey @sugaf1204, could you sign the CLI as per the bot response above?
also it looks like some linting/formatting needs to be done?
Thanks!

[sugaf1204]

Thanks for the reply.

I did format 83e8000.

What should I input in form(Please add the Canonical Project Manager or contact) in the Canonical CLA.

[SK1Y101]

Thanks for the reply.

I did format 83e8000.

What should I input in form(Please add the Canonical Project Manager or contact) in the Canonical CLA.

Hey @sugaf1204, you can put N/A for that box, or my name if you desire as we're currently interacting, I don't mind either

[sugaf1204]

@SK1Y101
Thank you! Completed!

[sugaf1204]

Hi @SK1Y101

Once again we have submitted a Canonical contributor licence agreement. Could you please check it?

[SK1Y101]

Hi @sugaf1204, could you push an empty commit to this branch to update the actions? I don't seem to be able to rerun the checks workflow right now

[sugaf1204]

@SK1Y101

I completed to push empty commit.
Thank you.

[skatsaounis]

Hi @sugaf1204 . Our CI is green and I am happy to accept the change as it is a bug fix. It would also be nice if you would extend both integration and unit tests to capture network_interface_info. But I am happy to approve the PR even without them. In case you are interested in writing some tests, you can draw inspiration from the existing ones of other modules. Just let me know 🙂

[sugaf1204]

@skatsaounis

Thanks for approval!
In our environment, we want this fix as soon as possible, so we'll have to wait until later to implement the test code.

In this repository, many feature that we needs is unimplemented, but it seems like that development status is not so active.
Will there be ongoing development in the future?

[SK1Y101]

Hi @sugaf1204!
Could you add an issue to implement the tests as skatsaounis mentioned? I'm also happy for this PR to land.

as for development, this repo isn't abandoned, but it isn't our priority. we are currently diverting more attention towards the terraform provider as we have more experience there as a team.