-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network_interface_info module #41
base: main
Are you sure you want to change the base?
Fix network_interface_info module #41
Conversation
@SK1Y101 |
5fa4ac2
to
463c8e4
Compare
Everyone contributing to this PR have now signed the CLA. Thanks! |
Hey @sugaf1204, could you sign the CLI as per the bot response above? |
Thanks for the reply. I did format 83e8000. What should I input in form( |
Hey @sugaf1204, you can put N/A for that box, or my name if you desire as we're currently interacting, I don't mind either |
@SK1Y101 |
Hi @SK1Y101 Once again we have submitted a Canonical contributor licence agreement. Could you please check it? |
Hi @sugaf1204, could you push an empty commit to this branch to update the actions? I don't seem to be able to rerun the checks workflow right now |
I completed to push empty commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sugaf1204 . Our CI is green and I am happy to accept the change as it is a bug fix. It would also be nice if you would extend both integration and unit tests to capture network_interface_info
. But I am happy to approve the PR even without them. In case you are interested in writing some tests, you can draw inspiration from the existing ones of other modules. Just let me know 🙂
Thanks for approval! In this repository, many feature that we needs is unimplemented, but it seems like that development status is not so active. |
Hi @sugaf1204! as for development, this repo isn't abandoned, but it isn't our priority. we are currently diverting more attention towards the terraform provider as we have more experience there as a team. |
This module accepts only
machine
andmac_address
parameter.Network_interface_info module calls
/MAAS/api/2.0/machines/
API withfqdn
query parameter.To transform
machine
tofqdn
, specifing name_field_ansible opt.ansible-collection/plugins/modules/network_interface_info.py
Line 136 in 7bb2a1b
Checklist before merging
tox -e format
tox -e sanity
tox -e units