Fix issue when reloading while a reload is pending. #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
bug
I noticed of an issue with the `MULTI_THREAD` feature, where an application would receive a `CancellationError` in the very rare (possible right now?) occurrence where we're reloading while a reload operation is already pending. We don't ever want to leak `CancellationError` which is just an internal mechanism. I thought that we can just ignore that one.
peaBerberian
force-pushed
the
fix/reload-reload
branch
from
96bf1c5
to
1ce1608
Compare
Florent-Bouisset
approved these changes
Sep 5, 2024
Hoping this is the same one, we should never have those visible in the API |
Yes it was on the TV you were remotely debugging I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed of an issue with the
MULTI_THREADfeature, where an application would receive aCancellationErrorin the very rare (possible right now?) occurrence where we're reloading while a reload operation is already pending.We don't ever want to leak
CancellationErrorwhich is just an internal mechanism. I thought that we can just ignore that one.NOTE: This was seen after testing #1523 on some devices