feature: log inbound context log to logger #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ore/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java
Fixed
Show fixed
Hide fixed
...ore/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java
Fixed
Show fixed
Hide fixed
...ore/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java
Fixed
Show fixed
Hide fixed
...ore/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java
Fixed
Show fixed
Hide fixed
...ore/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java
Fixed
Show fixed
Hide fixed
sbuettner
reviewed
Sep 10, 2024
|
|
||
| public DefaultInboundConnectorContextFactory( | ||
| final ObjectMapper mapper, | ||
| final InboundCorrelationHandler correlationHandler, | ||
| final SecretProviderAggregator secretProviderAggregator, | ||
| final ValidationProvider validationProvider, | ||
| final OperateClientAdapter operateClientAdapter) { | ||
| final OperateClientAdapter operateClientAdapter, | ||
| final boolean logWithLogger) { |
There was a problem hiding this comment.
Would not use the regular logging infra config. Just log debug and customers can enable the respective logger if they like to using env vars or an external logging config.
They can also just look into the rest endpoint.
There was a problem hiding this comment.
So no configurability at all. Instead just a debug logging that can be toggled? I am fine with that as well.
johnBgood
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #
Checklist
no milestonelabel.