Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add /connector-test endpoint to test outbound connector #3081

Closed
wants to merge 1 commit into from
Closed

feat: add /connector-test endpoint to test outbound connector #3081

wants to merge 1 commit into from

Conversation

markfarkas-camunda
Copy link
Contributor

Description

Hackdays project to test Outbound Connectors from web-modeler. A new /connector-test was added to trigger the execution of a connector.

@markfarkas-camunda markfarkas-camunda self-assigned this Aug 12, 2024
@markfarkas-camunda markfarkas-camunda added the kind:enhancement New feature or request label Aug 12, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2024
View reviewed changes
...ing/src/main/java/io/camunda/connector/runtime/test/ConnectorTestCompleteJobCommandImpl.java
}

@Override
public CompleteJobCommandStep1 variables(InputStream variables) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note test

Method ConnectorTestCompleteJobCommandImpl.variables(..) could be confused with overloaded method
variables
Loading
, since dispatch depends on static types.
...ing/src/main/java/io/camunda/connector/runtime/test/ConnectorTestCompleteJobCommandImpl.java
}

@Override
public CompleteJobCommandStep1 variables(Object variables) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note test

Method ConnectorTestCompleteJobCommandImpl.variables(..) could be confused with overloaded method
variables
Loading
, since dispatch depends on static types.
Method ConnectorTestCompleteJobCommandImpl.variables(..) could be confused with overloaded method
variables
Loading
, since dispatch depends on static types.
...nector-runtime-spring/src/main/java/io/camunda/connector/runtime/test/ConnectorTestImpl.java
this.objectMapper = objectMapper;
}

public void test(ConnectorTestRq req) throws Exception {

Check notice

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
ConnectorTest.test
Loading
; it is advisable to add an Override annotation.
@sbuettner
Copy link
Contributor

Hey @markfarkas-camunda, can we close this one and re-open if necessary?

@markfarkas-camunda
Copy link
Contributor Author

Based on the decision here, we won't have a dedicated endpoint for this purpose in the connectors repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markfarkas-camunda markfarkas-camunda

Labels
kind:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markfarkas-camunda @sbuettner