fix(rest): Ensure proper URL encoding + fix case issues with content type headers #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
commented
Jul 8, 2024
| @@ -71,11 +71,11 @@ public void build(ClassicRequestBuilder builder, HttpCommonRequest request) { | |||
| private HttpEntity createEntityForContentType( | |||
| ContentType contentType, Map<?, ?> body, HttpCommonRequest request) { | |||
| HttpEntity entity; | |||
| if (contentType.getMimeType().equals(MULTIPART_FORM_DATA.getMimeType())) { | |||
| if (contentType.getMimeType().equalsIgnoreCase(MULTIPART_FORM_DATA.getMimeType())) { | |||
There was a problem hiding this comment.
Even parsed, Apache stores the initial value (could be case inconsistent)
sbuettner
reviewed
Jul 8, 2024
Comment on lines
37
to
43
| // We try to decode the URL first, because it might be encoded already | ||
| // which would lead to double encoding. Decoding is safe here, because it does nothing if | ||
| // the URL is not encoded. | ||
| var decodedUrl = | ||
| URLDecoder.decode( | ||
| Optional.ofNullable(request.getUrl()).orElse(""), StandardCharsets.UTF_8); | ||
| var url = new URL(decodedUrl); |
There was a problem hiding this comment.
For easier maintenance and testability, could you extract this into a static utility method?
This and the other part and simply return a string.
sbuettner
approved these changes
Jul 8, 2024
johnBgood
deleted the
840-rest-connector-handle-spaces-in-url-path-seond-part
branch
|
Successfully created backport PR for |
johnBgood
added a commit
that referenced
this pull request
Jul 8, 2024
…type headers (#2826) (#2827) * fix(rest): Ensure proper URL encoding + fix case issues with content type headers (cherry picked from commit e07b88c) Co-authored-by: Jonathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes https://github.com/camunda/team-connectors/issues/840