feat(logging): Introduce InvalidInboundConnectorException and adjust log level for missing definitions #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log level for missing definitions
|
Should we add here backport labels for prev versions? |
sbuettner
reviewed
Feb 15, 2024
...src/main/java/io/camunda/connector/api/error/InvalidInboundConnectorDefinitionException.java
Outdated
Show resolved
Hide resolved
…itionException to runtime-core
…ility to add more context information
sbuettner
approved these changes
Feb 16, 2024
Oleksiivanov
deleted the
1955-exception-handling-for-missing-event-definitions-in-inbound-connector-elements
branch
|
/backport |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
…log level for missing definitions (#1956) * feat(logging): Introduce InvalidInboundConnectorException and adjust log level for missing definitions * feat(logging): improve log message, move InvalidInboundConnectorDefinitionException to runtime-core * feat(logging): added to InvalidInboundConnectorDefinitionException ability to add more context information (cherry picked from commit c879a98)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
…log level for missing definitions (#1956) * feat(logging): Introduce InvalidInboundConnectorException and adjust log level for missing definitions * feat(logging): improve log message, move InvalidInboundConnectorDefinitionException to runtime-core * feat(logging): added to InvalidInboundConnectorDefinitionException ability to add more context information (cherry picked from commit c879a98)
|
Successfully created backport PR for |
chillleader
pushed a commit
that referenced
this pull request
Feb 26, 2024
…log level for missing definitions (#1956) * feat(logging): Introduce InvalidInboundConnectorException and adjust log level for missing definitions * feat(logging): improve log message, move InvalidInboundConnectorDefinitionException to runtime-core * feat(logging): added to InvalidInboundConnectorDefinitionException ability to add more context information (cherry picked from commit c879a98)
chillleader
pushed a commit
that referenced
this pull request
Feb 26, 2024
…log level for missing definitions (#1956) * feat(logging): Introduce InvalidInboundConnectorException and adjust log level for missing definitions * feat(logging): improve log message, move InvalidInboundConnectorDefinitionException to runtime-core * feat(logging): added to InvalidInboundConnectorDefinitionException ability to add more context information (cherry picked from commit c879a98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
InvalidInboundConnectorExceptionclass. This exception is specifically thrown in cases where the sanity check for connector definitions fails, such as when the required event definitions are missing.Modified the error handling strategy within the getCorrelationPointForElement method to catch InvalidInboundConnectorException and log it as a warning. This adjustment is made to ensure consistency in how we handle and log similar errors across different connector processing methods, such as getCorrelationPointForStartEvent, where similar issues could arise.
Related issues
closes #
#1955